fix: Set nifti_header.axis_codes to null for bad qforms, rather than error #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
+ Coverage 86.99% 87.03% +0.03%
==========================================
Files 50 50
Lines 3721 3724 +3
Branches 610 613 +3
==========================================
+ Hits 3237 3241 +4
+ Misses 475 474 -1
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
effigies
changed the title
rwblair
approved these changes
Nov 24, 2025
Contributor
Author
|
Just a note that there's a related upstream fix: rii-mango/NIFTI-Reader-JS#56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #112 we added
axis_codesto thenifti_headercontext, which unwittingly made the whole header appear unreadable for improper quaternions (the norm of the quaternion should be 1; if the norm of the explicit components exceeds 1, the implicit component can't be calculated). Raising an error in this case is not worth it, since it only enables a warning check.I've seen two reports in the last week about surprising
NIFTI_HEADER_UNREADABLEerrors (OpenNeuro support ticket and https://neurostars.org/t/bids-validator-error-nifti-header-unreadable/34423), which result from this.